Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java Version Model Feature to add Minecraft 1.19 error #5147

Open
wants to merge 1 commit into
base: 1.0-develop
Choose a base branch
from

Conversation

danny6167
Copy link
Member

Adds the minecraft 1.19 requires running the server with java 17 or above variant of the error message to the Java Version model

@Jcodeerd
Copy link

Jcodeerd commented Jul 1, 2024

Might also want to add the errors for 1.20 and 1.21?

@danny6167
Copy link
Member Author

Paper 1.19, 1.20, and 1.21 all say that same error message with the version as 1.19.
Currently waiting for my internet to behave to confirm what Vanilla says.

@danny6167 danny6167 marked this pull request as draft July 1, 2024 18:18
@danny6167
Copy link
Member Author

Vanilla doesn't produce this message at all and is already caught by the existing match lines. This PR is good to go as is.

@danny6167 danny6167 marked this pull request as ready for review July 1, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Awaiting merge
Development

Successfully merging this pull request may close these issues.

2 participants